ParseXS: fix handling of empty C_ARGS etc #23408
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GH#23407
My recent refactoring work on ParseXS made the parser go into an
infinite loop on multiline_merged nodes such as C_ARGS when there was no
text, e.g.
void
foo(int a)
C_ARGS:
jkeenan
requested changes
Jul 7, 2025
There was a problem hiding this comment.
Note: In the first line of the body of the commit message, I believe there should be a wordspace between GH and #. This would enable Github to create a URL.
Took a test-driven-development approach. First, locally cloned blead and added change in dist/ExtUtils-ParseXS/t/001-basic.t. Configured, built, ran that test file through harness. That operation nearly froze my machine, but eventually the program crash landed with:
ok 171 - autocall args C_ARGS: no errors expected
All 171 subtests passed
Test Summary Report
-------------------
../dist/ExtUtils-ParseXS/t/001-basic.t (Wstat: 9 (Signal: KILL) Tests: 171 Failed: 0)
Non-zero wait status: 9
Parse errors: No plan found in TAP output
Files=1, Tests=171, 24 wallclock secs ( 0.02 usr 0.01 sys + 8.04 cusr 11.34 csys = 19.41 CPU)
Result: FAIL
Then created a local branch from the p.r. Configured, built, ran the test file. File went to completion:
ok
All tests successful.
Files=1, Tests=915, 6 wallclock secs ( 0.10 usr 0.02 sys + 4.34 cusr 1.49 csys = 5.95 CPU)
Result: PASS
mauke
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH#23407
My recent refactoring work on ParseXS made the parser go into an infinite loop on multiline_merged nodes such as C_ARGS when there was no text, e.g.